Workflow file update

gansm · Sep 17, 2024 · c9fb675 · c9fb675
1 parent dea7b94
commit c9fb675
Show file tree

Hide file tree

Showing 14 changed files with 25 additions and 18 deletions.
diff --git a/.github/workflows/alpine.yml b/.github/workflows/alpine.yml
@@ -16,7 +16,7 @@ jobs:
       uses: actions/checkout@v3
 
     - name: Install latest Alpine Linux
-      uses: jirutka/setup-alpine@v1
+      uses: jirutka/setup-alpine@v1  # see https://github.com/jirutka/setup-alpine
       with:
         arch: x86_64
         branch: latest-stable

diff --git a/.github/workflows/arm.yml b/.github/workflows/arm.yml
@@ -26,7 +26,7 @@ jobs:
       uses: actions/checkout@v3
 
     - name: Test on ARM architecture
-      uses: uraimo/run-on-arch-action@v2
+      uses: uraimo/run-on-arch-action@v2  # see https://github.com/uraimo/run-on-arch-action
       id: runcmd
       with:
         arch: ${{ matrix.arch }}

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -38,7 +38,7 @@ jobs:
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v2
+      uses: github/codeql-action/init@v2  # see https://github.com/github/codeql-action
       with:
         languages: ${{ matrix.language }}
         # If you wish to specify custom queries, you can do so here or in a config file.

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -45,7 +45,7 @@ jobs:
       run: sudo gem install coveralls-lcov
 
     - name: Build with with gcov
-      run: script -e -c "./build.sh coverage"
+      run: script -q -e -c './build.sh coverage'
 
     - name: Generate lcov.info and publish to coveralls.io
       run: |
@@ -66,5 +66,5 @@ jobs:
         gpgv codecov.SHA256SUM.sig codecov.SHA256SUM
         shasum -a 256 -c codecov.SHA256SUM
         chmod +x codecov
-        ./codecov
+        ./codecov -t ${{ secrets.CODECOV_TOKEN }}
 
diff --git a/.github/workflows/coverity-scan.yml b/.github/workflows/coverity-scan.yml
@@ -76,7 +76,7 @@ jobs:
 
     - name: Make unit test
       run: |
-        script -e -c "make check" && RET=$? || RET=$?
+        script -q -e -c 'make check' && RET=$? || RET=$?
         cat test/*.log || echo
         echo "Exit status: $RET"
         exit "$RET"

diff --git a/.github/workflows/cygwin.yml b/.github/workflows/cygwin.yml
@@ -25,7 +25,7 @@ jobs:
       uses: actions/checkout@v3
 
     - name: Install Cygwin
-      uses: cygwin/cygwin-install-action@v3
+      uses: cygwin/cygwin-install-action@v3  # see https://github.com/cygwin/cygwin-install-action
       with:
         platform: ${{ matrix.platform }}
         install-dir: C:\cygwin

diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml
@@ -17,7 +17,7 @@ jobs:
       uses: actions/checkout@v3
 
     - name: Test on FreeBSD 13.1
-      uses: cross-platform-actions/action@v0.10.0
+      uses: cross-platform-actions/action@v0  # see https://github.com/cross-platform-actions/action
       with:
         operating_system: freebsd
         version: '13.1'

diff --git a/.github/workflows/netbsd.yml b/.github/workflows/netbsd.yml
@@ -17,7 +17,7 @@ jobs:
       uses: actions/checkout@v3
 
     - name: Test on NetBSD 9.3
-      uses: cross-platform-actions/action@v0.22.0
+      uses: cross-platform-actions/action@v0  # see https://github.com/cross-platform-actions/action
       with:
         operating_system: netbsd
         version: '9.3'

diff --git a/.github/workflows/openbsd.yml b/.github/workflows/openbsd.yml
@@ -17,7 +17,7 @@ jobs:
       uses: actions/checkout@v3
 
     - name: Test on OpenBSD 7.2
-      uses: cross-platform-actions/action@v0.10.0
+      uses: cross-platform-actions/action@v0  # see https://github.com/cross-platform-actions/action
       with:
         operating_system: openbsd
         version: '7.2'

diff --git a/.github/workflows/solaris.yml b/.github/workflows/solaris.yml
@@ -17,8 +17,9 @@ jobs:
       uses: actions/checkout@v4
 
     - name: Test on Solaris 11.4
-      uses: vmactions/solaris-vm@v1
+      uses: vmactions/solaris-vm@v1  # see https://github.com/vmactions/solaris-vm
       with:
+        release: "11.4-gcc"
         prepare: |
           pkg publisher solaris
           beadm list

diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
@@ -64,4 +64,3 @@ jobs:
         ./configure --prefix=/usr
         /tmp/build-wrapper-linux-x86/build-wrapper-linux-x86-64 --out-dir bw-output make all
         /tmp/sonar-scanner-${LATEST_VERSION}-linux-x64/bin/sonar-scanner
-
diff --git a/final/eventloop/eventloop-class-diagram.txt b/final/eventloop/eventloop-class-diagram.txt
@@ -10,5 +10,8 @@
   │ Monitor │◄───┼───┤ TimerMonitorImpl │                    ├──┤ TimerMonitor │
   └─────────┘    │   └─────────────────┬┘                    │  └──────────────┘
                  │   ┌───────────┐     ▲   ┌─────────────┐   │
-                 └───┤ IoMonitor │     └───┤ KqueueTimer │◄──┘
-                     └───────────┘         └─────────────┘
+                 ├───┤ IoMonitor │     └───┤ KqueueTimer │◄──┘
+                 │   └───────────┘         └─────────────┘
+                 │   ┌────────────────┐
+                 └───┤ BackendMonitor │
+                     └────────────────┘
diff --git a/final/output/tty/foptiattr.cpp b/final/output/tty/foptiattr.cpp
@@ -1264,8 +1264,8 @@ inline void FOptiAttr::change_current_color ( const FChar& term
     return true;
   };
 
-  const auto& apply_AF_AB = apply_color_change(AF, AB, VGA);
-  const auto& apply_Sf_Sb = apply_color_change(Sf, Sb, ANSI);
+  const bool apply_AF_AB = apply_color_change(AF, AB, VGA);
+  const bool apply_Sf_Sb = apply_color_change(Sf, Sb, ANSI);
 
   if ( apply_AF_AB || apply_Sf_Sb || ! sp )
     return;

diff --git a/test/eventloop-monitor-test.cpp b/test/eventloop-monitor-test.cpp
@@ -511,6 +511,10 @@ class StringParser
     {
       auto callback = [this, eloop] (const finalcut::Monitor*, short)
                       {
+                        // After a backend event is triggered, this event
+                        // handling code is called by the dispatcher
+                        // of the event loop. Immediately before this call,
+                        // the triggering event has already been destroyed.
                         std::cout << "BackendMonitor callback handle";
                         processQueuedInput();
                         eloop->leave();
@@ -560,7 +564,7 @@ void StringParser::parseString()
     number_queue.push_back(number_string.toInt());
 
   if ( is_empty_before && ! number_queue.empty() )
-    queue_monitor.setEvent();
+    queue_monitor.setEvent();  // This line creates the event
 }
 
 //----------------------------------------------------------------------
@@ -895,7 +899,7 @@ void EventloopMonitorTest::BackendMonitorTest()
   std::cout << "\n";
   CPPUNIT_ASSERT ( string_parser.getQueue().empty() );
   // The queue receives data and sends a backend event
-  string_parser.parseString();
+  string_parser.parseString();  // Create a backend event in the self-pipe
   CPPUNIT_ASSERT ( ! string_parser.getQueue().empty() );
   CPPUNIT_ASSERT ( string_parser.getQueue().size() == 9 );
   CPPUNIT_ASSERT ( eloop.run() == 0 );  // Run event loop