Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloning/building packages given as ORG/REPO #38

Open
wilfwilson opened this issue Mar 7, 2022 · 2 comments
Open

Cloning/building packages given as ORG/REPO #38

wilfwilson opened this issue Mar 7, 2022 · 2 comments

Comments

@wilfwilson
Copy link
Contributor

Similar to #35, but not the same:

If I specify eg GAP_PKGS_TO_CLONE as digraphs/digraphs, then the command rm -rf "$pkg"*, which translates to rm -rf "digraphs/digraphs"*, fails to delete digraphs-1.3.1.

If I also have GAP_PKGS_TO_BUILD as digraphs, then both versions of Digraphs get compiled. This wastes a lot of time.

@wilfwilson
Copy link
Contributor Author

This is causing the Semigroups package CI to fail, see semigroups/Semigroups#815 (comment) and subsequent comments.

james-d-mitchell added a commit to james-d-mitchell/setup-gap that referenced this issue Apr 14, 2022
@fingolfin
Copy link
Member

Note that one can even specify full URLs to clone, then it'll be similar.

AS it is, GAP_PKGS_TO_CLONE is a crutch, and perhaps we'd be better off eliminating it outright. Packages that need to clone (and possibly build) additional packages can easily achieve that by inserting a suitable extra step in their CI.yml.

fingolfin pushed a commit that referenced this issue Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants