Use size and mtime to determine if a file has changed rather than hash #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #459 and fixes #59
Explanation:
Comparing etags to the MD5 hash of each file is, imo, an inferior method for these reasons:
Instead, comparing the size and the modification time is robust enough that I think it's fine to be the default method. It's the method used by the sync function included in the AWS CLI so if it's good enough there I reckon it's also good enough here.