chore(gatsby): convert build-html to typescript #20535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
added
the
type: maintenance
blainekasten
added
the
bot: merge on green
acao
reviewed
Jan 12, 2020
ascorbic
suggested changes
Jan 15, 2020
| const buildRenderer = async ( | ||
| program: IProgram, | ||
| stage: BuildHTMLStage, | ||
| parentSpan: IActivity |
There was a problem hiding this comment.
parentSpan is destructured in the previous code. Was that a mistake? It does seem a bit odd to destructure it then immediately recreate the object below.
There was a problem hiding this comment.
ascorbic
reviewed
Jan 16, 2020
ascorbic
previously approved these changes
Jan 23, 2020
| nodes?: any // TODO | ||
| nodesByType: Map<any, any> // TODO | ||
| status: ProgramStatus | ||
| nodes?: { |
There was a problem hiding this comment.
If you extract this into an interface, you can then easily type nodesByType below
There was a problem hiding this comment.
sounds great, i'll follow that up in a future PR. I didn't fully understand yet what nodesByType was
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
commands/build-htmlto typescript. Also moves some shared types in the commands folder into a relative/typesfolder. There is likely a use-case to move the shared types even further up, but I'm thinking we'll wait until that structure becomes more obvious