Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): migrate themes reducer to TypeScript #23716

Merged
merged 1 commit into from
May 4, 2020

Conversation

taejs
Copy link
Contributor

@taejs taejs commented May 3, 2020

Description

migrate themes reducer to TypeScript

Related Issues

Related to #21995

@taejs taejs requested a review from a team as a code owner May 3, 2020 14:23
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 3, 2020
@taejs
Copy link
Contributor Author

taejs commented May 3, 2020

I'd like to change type of themes property any to custom type.

themes: any // TODO

Then I have to debug bootstrap/index.js,
How can I debug it? I've tried, but It can't be tested

@ascorbic
Copy link
Contributor

ascorbic commented May 4, 2020

@taejs Adding types shouldn't require any debugging of js files, as long as you aren't changing any runtime behaviour or exports. I'd do this in another PR as part of a migration of bootstrap/load-themes rather than as part of this.

@ascorbic ascorbic merged commit 2a586c9 into gatsbyjs:master May 4, 2020
@gatsbot
Copy link

gatsbot bot commented May 4, 2020

Holy buckets, @taejs — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wardpeet wardpeet removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants