-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gatsby-image] Support image loading with JavaScript disabled #3122
[gatsby-image] Support image loading with JavaScript disabled #3122
Conversation
Deploy preview ready! Built with commit 896c187 |
Deploy preview ready! Built with commit 2fb97a0 |
Thanks! Sorry for the long delay on getting this out there — been super busy 😅 |
@KyleAMathews You needn’t be sorry, I can totally understand your situation of being extremely busy. I’m glad that this has finally been merged, I highly appreciate your efforts and attitude towards this project! 😊 |
@KyleAMathews I don't know why, but this seems to break production builds (
Development builds are fine ( |
Can you try to duplicate this with the using-gatsby-image example site? |
@KyleAMathews Just visit https://using-gatsby-image.gatsbyjs.org using Chrome v63. It's pretty ironic that gatsby-image now works without JavaScript, but doesn't work with JS enabled. |
Huh... weird this didn't show up in your and my testing. |
This is the issue we're running into facebook/react#1252 |
looks like we still have to use |
I'll work on a PR to do this. |
Resolves #3109.