-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(contentful): reenable support for gif images #31986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jun 18, 2021
Will remove the draft as soon the API fix is deployed. |
The fix is rolled out :) |
axe312ger
added
status: needs core review
Currently awaiting review from Core team member
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Jun 19, 2021
wardpeet
approved these changes
Jun 22, 2021
wardpeet
added
topic: source-contentful
Related to Gatsby's integration with Contentful
and removed
status: needs core review
Currently awaiting review from Core team member
labels
Jun 22, 2021
vladar
pushed a commit
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit a30aa0b)
gatsbybot
pushed a commit
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit a30aa0b) Co-authored-by: Benedikt Rötsch <[email protected]>
This was referenced Jun 23, 2021
This was referenced Jan 18, 2022
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the rewrite to gatsby-plugin-image and Gatsby v3 we are more strict when calling the Contentful Images API
Unfortunately, as we now always pass a image format. This broke gif support:
Before we called like this:
https://images.ctfassets.net/k8iqpp6u0ior/2uMYE0Za3MOF9eVrx7eyiW/ace850f7bf6cbf52e3922b5db8379b7a/gatsby-monogram-animated.gif?w=150
Now we call like this:
https://images.ctfassets.net/k8iqpp6u0ior/2uMYE0Za3MOF9eVrx7eyiW/ace850f7bf6cbf52e3922b5db8379b7a/gatsby-monogram-animated.gif?w=150&fm=gif
Which unfortunately fails:
Good news: This is a configuration bug in the Contentful API and will be fixed very very soon.
This patch allows gifs now as image format as well :)