fix(gatsby): add react-com as devDep #32865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dev-dependency on
@types/react-dom
, missed in #22854 ❤️yarn typecheck
currently passes becausenode_modules
contains@types/react-dom
-- I think becausegatsby-plugin-image
already dev-depends on it? Howeverpackages/gatsby/index.d.ts
depends on@types/react-dom
since #22854.My Gatsby project doesn't have an existing dependency on
gatsby-plugin-image
or@types/react-dom
, so I get the following error when I typecheck my project:This PR addresses that by adding the previously-undeclared dev-dependency.