Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing environment variable for secure endpoint #513

Merged
merged 5 commits into from
Apr 22, 2023

Conversation

kinoute
Copy link
Contributor

@kinoute kinoute commented Apr 20, 2023

Following #512, we need to add support for the "secure endpoint" parameter through environment variables. I also added a default value for the chunked request size (found in the java code source) since an empty value will raise an exception:

[s3proxy] E 04-20 10:16:36.854 main org.gaul.s3proxy.Main:279 |::] java.lang.NumberFormatException: For input string: ""
[s3proxy] E 04-20 10:16:36.855 main org.gaul.s3proxy.Main:279 |::]     at java.base/java.lang.NumberFormatException.forInputSt
[s3proxy] E 04-20 10:16:36.855 main org.gaul.s3proxy.Main:279 |::]     at java.base/java.lang.Long.parseLong(Unknown Source)
[s3proxy] E 04-20 10:16:36.855 main org.gaul.s3proxy.Main:279 |::]     at java.base/java.lang.Long.parseLong(Unknown Source)
[s3proxy] E 04-20 10:16:36.856 main org.gaul.s3proxy.Main:279 |::]     at org.gaul.s3proxy.S3Proxy$Builder.fromProperties(S3Pr
[s3proxy] E 04-20 10:16:36.856 main org.gaul.s3proxy.Main:279 |::]     at org.gaul.s3proxy.Main.main(Main.java:158)

@kinoute
Copy link
Contributor Author

kinoute commented Apr 20, 2023

Also added the 443 port to the Dockerfile

@gaul
Copy link
Owner

gaul commented Apr 20, 2023

Could you rebase this PR to resolve the conflicts?

Also could you add some documentation to README.md on how users need to configure the keystore and their clients?

@kinoute kinoute reopened this Apr 21, 2023
@kinoute
Copy link
Contributor Author

kinoute commented Apr 21, 2023

I edited the SSL Support page and the README.md file to add a link to this page: https://github.com/gaul/s3proxy/wiki/SSL-support

@gaul gaul merged commit f84bec3 into gaul:master Apr 22, 2023
@gaul
Copy link
Owner

gaul commented Apr 22, 2023

Thank you for your contribution @kinoute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants