Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech refresh & migrate from Travis to GitHub Actions #143

Closed
16 tasks done
gazbert opened this issue Dec 11, 2021 · 3 comments
Closed
16 tasks done

Tech refresh & migrate from Travis to GitHub Actions #143

gazbert opened this issue Dec 11, 2021 · 3 comments
Assignees
@gazbert
Labels
build issue enhancement
Milestone
Tech Refresh Release

Comments

@gazbert
Copy link
Owner

gazbert commented Dec 11, 2021 •
edited
Loading

Stuff outstanding:

  • Upgrade to JUnit5 - finally!
  • Powermock not playing with JUnit 5 when mocking final classes - stuck on JUnit4 for tests using Powemock. See: Is powermock team working on JUnit5? powermock/powermock#929
  • Maven assembly plugin fix.
  • Fix rogue Javadoc errors in Maven build.
  • Gradle build.
  • README updates etc
  • Fix Gradle SpotBugs task on 7.3.3
  • H2 version bump.
  • Fix circular ref in WebSecurityConfig bean.
  • Fix for missing Spring Cloud Restart bean.
  • Fix for missing LogFileWebEndpoint bean.

Bot is now up and running on Boot 2.6.4 :-)

  • Verify OpenAPI docs (+ app config props) look ok?
  • Fix broken BotLogfileServiceImpl - latest Actuator LogFileWebEndpoint::logFile() is returning null Resource :-( Probably related to TestBotLogfileService is failing #144
  • Verify test coverage % is consistent in maven + gradle builds. Can it be increased?
  • Verify all FIXMEs and TODOs done?
  • Verify Docker build ok?
@gazbert gazbert self-assigned this Dec 11, 2021
@gazbert gazbert pinned this issue Dec 11, 2021
@gazbert
Copy link
Owner Author

gazbert commented Dec 11, 2021

All the deps need updating.
Spring Boot 2.6.x etc...

Also binning Travis - crazy OSS 'pricing' model...
Moving to Gradle build run by GitHub Actions + integration with SonarQube.

gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Added GitHub Actions build status badge
5db4891
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Fix typo
59f473a
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Start wiring up SonarCloud
5c78e9b
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Fixed build badge
b8ccb14
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Removed all refs to Travis
3b0e33c
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Run exchange IT tests as part of GitHub Actions CI build
21ba28e
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Remove verbose Gradle output
aec89ef
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Experiment with maven GitHub Actions CI build
80c1c5b
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Try with diff maven token
2e539a5
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Remove dup sonar prop
db1eda9
gazbert added a commit that referenced this issue Dec 11, 2021
@gazbert
#143 : Hack to get around sonar project key issue with maven multi mo…
e928417 
…d pom ;-/
@gazbert gazbert changed the title Tech refresh of dependencies + migrate from Travis to GitHub Actions Tech refresh & migrate from Travis to GitHub Actions Dec 11, 2021
gazbert added a commit that referenced this issue Dec 13, 2021
@gazbert
#143 : Updated non-Spring deps for Maven
04329d3
gazbert added a commit that referenced this issue Dec 13, 2021
@gazbert
#143 : Revert back to h2 1.4.200
3379b87
gazbert added a commit that referenced this issue Dec 13, 2021
@gazbert
#143 : Update maven spotbugs plugin to 4.2.3 - later versions flaky
6a7cfd3
gazbert added a commit that referenced this issue Dec 13, 2021
@gazbert
#143 : Fixed h2 constraint errors in REST API unit tests
72b7234
gazbert added a commit that referenced this issue Dec 31, 2021
@gazbert
#143 : Upgrade to Boot 2.6.2 and started upgrade to OpenAPI docs 3 + …
bf5ea33 
…Junit5
gazbert added a commit that referenced this issue Dec 31, 2021
@gazbert
#143 : Downgraded to Junit4 for mods with Powermock tests
54e6f06 
* See: powermock/powermock#929
gazbert added a commit that referenced this issue Dec 31, 2021
@gazbert
#143 : Sonar fixes. happy new year
e1e7a87
gazbert added a commit that referenced this issue Dec 31, 2021
@gazbert
#143 : Sonar fixes. happy new year
b93090c
gazbert added a commit that referenced this issue Jan 1, 2022
@gazbert
#143 : Migrate bxbot-core to JUnit5
6e89855
@gazbert gazbert added this to the Tech Refresh Release milestone Jan 1, 2022
gazbert added a commit that referenced this issue Jan 11, 2022
@gazbert
#143 : Use JUnit 5 assertions in bxbot-core wherever possible
d703dd9
gazbert added a commit that referenced this issue Jan 11, 2022
@gazbert
#143 : Upgrade bxbot-domain-objects to JUnit 5
9cff40e
gazbert added a commit that referenced this issue Feb 15, 2022
@gazbert
#143 : Upgrade Gradle enterprise plugin to latest
22a99d5
gazbert added a commit that referenced this issue Feb 15, 2022
@gazbert
#143 : Added gradlePluginPortal() - GitHub Actions can't find Gradle …
caaa3d6 
…enterprise plugin all of a sudden... ;-/
gazbert added a commit that referenced this issue Feb 19, 2022
@gazbert
#143 : Upgrade to latest H2
18222ea 
REST API tests failing due to circular dependency in WebSecurityConfig - next on the list!
gazbert added a commit that referenced this issue Feb 19, 2022
@gazbert
#143 : Fix Gradle build Sonar coverage for bxbot-services
f690217
gazbert added a commit that referenced this issue Feb 19, 2022
@gazbert
#143 : Fix Gradle build Sonar coverage for bxbot-services - again!
4f83982
gazbert added a commit that referenced this issue Feb 22, 2022
@gazbert
#143 : Fixed circular reference problem in WebSecurityConfig - ouch!
fe52741
gazbert added a commit that referenced this issue Feb 23, 2022
@gazbert
#143 : Fixed missing RestartEndpoint bean
14468f7
gazbert added a commit that referenced this issue Feb 23, 2022
@gazbert
#143 : Fixed missing LogFileWebEndpoint bean
98d03ff 
Very subtle change!
gazbert added a commit that referenced this issue Feb 25, 2022
@gazbert
#143 : Fixed issues with SpringDocs + Swagger auth
bdf6657
gazbert added a commit that referenced this issue Feb 26, 2022
@gazbert
#143 : Improve SpringDocs for domain objects, zzz...
e60ed5f
gazbert added a commit that referenced this issue Feb 26, 2022
@gazbert
#143 : Fix checkstyle issue
9776598
gazbert added a commit that referenced this issue Feb 26, 2022
@gazbert
#143 : Upgrade maven dependencies
5df9880
gazbert added a commit that referenced this issue Feb 26, 2022
@gazbert
#143 : Upgrade gradle dependencies
fdf1214
gazbert added a commit that referenced this issue Feb 26, 2022
@gazbert
#143 : Correct filenames in Dockerfile
1325b0e
gazbert added a commit that referenced this issue Feb 27, 2022
@gazbert
#143 : Fixed LogFileWebEndpoint log file location issue
e681ed6
gazbert added a commit that referenced this issue Feb 27, 2022
@gazbert
#143 : Fixed Gradle dist creation - DSL changed again!
b5608bb
gazbert added a commit that referenced this issue Mar 1, 2022
@gazbert
#143 : README updates for Springdocs
ee7f2cf
gazbert added a commit that referenced this issue Mar 1, 2022
@gazbert
#143 : Increase bxbot-core coverage back to 80% for maven build
66db992 
Gradle build jacoco task needs fixing...
gazbert added a commit that referenced this issue Mar 2, 2022
@gazbert
#143 : Increase bxbot-exchanges coverage back to 80% for maven build
25b3f2a
gazbert added a commit that referenced this issue Mar 3, 2022
@gazbert
#143 : Increase bxbot-strategies coverage back to 80% for maven build
a0a608c
gazbert added a commit that referenced this issue Mar 3, 2022
@gazbert
#143 : JaCoCo still broken for bxbot-rest-api - needs investigating
465b7d9 
Coverage is 0.7 with maven, so releasing anyway.
gazbert added a commit that referenced this issue Mar 3, 2022
@gazbert
Merge tech-refresh branch to master (#147)
f2fcb57 
* #143 : Added GitHub Actions build status badge

* #143 : Fix typo

* #143 : Start wiring up SonarCloud

* #143 : Fixed build badge

* #143 : Removed all refs to Travis

* #143 : Run exchange IT tests as part of GitHub Actions CI build

* #143 : Remove verbose Gradle output

* #143 : Experiment with maven GitHub Actions CI build

* #143 : Try with diff maven token

* #143 : Remove dup sonar prop

* #143 : Hack to get around sonar project key issue with maven multi mod pom ;-/

* #143 : Updated non-Spring deps for Maven

* #143 : Revert back to h2 1.4.200

* #143 : Update maven spotbugs plugin to 4.2.3 - later versions flaky

* #143 : Fixed h2 constraint errors in REST API unit tests

* #143 : Upgrade to Boot 2.6.2 and started upgrade to OpenAPI docs 3 + Junit5

* #143 : Downgraded to Junit4 for mods with Powermock tests

* See: powermock/powermock#929

* #143 : Sonar fixes. happy new year

* #143 : Sonar fixes. happy new year

* #143 : Migrate bxbot-core to JUnit5

* #143 : Use JUnit 5 assertions in bxbot-core wherever possible

* #143 : Upgrade bxbot-domain-objects to JUnit 5

* #143 : Use JUnit 5 wherever possible in bxbot-exchanges

* #143 : Upgrade to JUnit 5 in bxbot-services

* #143 : Upgrade to JUnit 5 in bxbot-strategy-api

* #143 : Removed explicit junit4 dependency + use junit-vintage-engine instead

* #143 : Upgrade to JUnit 5 in bxbot-trading-api

* #143 : Fix checkstyle issues

* #143 : Upgrade to JUnit 5 in bxbot-yaml-datastore

* #143 : Finally removed explicit JUnit 4 dependency :-)

* #143 : Upgraded Gradle build to 7.3.3 + dependency updates

* Exchange IT test needs sorting in Gradle build
* SpotBugs plugin needs fixing
* Double check coverage % Gradle + Maven mods - seems wrong - REST API especially
* Fix Gradle 8 deprecation warnings
* Fix JaCoCo warnings

* #143 : Trigger Gradle GitHub build

* #143 : Disable integrationTests on Gradle GitHub build until fixed...

* #143 : Fixed Gradle integrationTests

* #143 : Fixed Maven Javadoc plugin 'errors' and started fixing warnings

* #143 : Fixed Checkstyle moans

* #143 : Fixed more maven javadoc whines...

* #143 : Added Maven CI badge to README

* #143 : Fixed maven assembly plugin issues

* Fixed non-portable root paths for maven assembly plugin.
* Removed unused filesets.
* Use latest xmlns.

* #143 : Upgrade to Boot 2.6.3 + latest maven-assembly-plugin

* #143 : Fixed Gradle spotbugs plugin execution

Added bunch of minor SpotBugs warnings to excludes filter file too.

* #143 : Upgrade Gradle enterprise plugin to latest

* #143 : Added gradlePluginPortal() - GitHub Actions can't find Gradle enterprise plugin all of a sudden... ;-/

* #143 : Upgrade to latest H2

REST API tests failing due to circular dependency in WebSecurityConfig - next on the list!

* #143 : Fix Gradle build Sonar coverage for bxbot-services

* #143 : Fix Gradle build Sonar coverage for bxbot-services - again!

* #143 : Fixed circular reference problem in WebSecurityConfig - ouch!

* #143 : Fixed missing RestartEndpoint bean

* #143 : Fixed missing LogFileWebEndpoint bean

Very subtle change!

* #143 : Fixed issues with SpringDocs + Swagger auth

* #143 : Improve SpringDocs for domain objects, zzz...

* #143 : Fix checkstyle issue

* #143 : Upgrade maven dependencies

* #143 : Upgrade gradle dependencies

* #143 : Correct filenames in Dockerfile

* #143 : Fixed LogFileWebEndpoint log file location issue

* #143 : Fixed Gradle dist creation - DSL changed again!

* #143 : README updates for Springdocs

* #143 : Increase bxbot-core coverage back to 80% for maven build

Gradle build jacoco task needs fixing...

* #143 : Increase bxbot-exchanges coverage back to 80% for maven build

* #143 : Increase bxbot-strategies coverage back to 80% for maven build

* #143 : JaCoCo still broken for bxbot-rest-api - needs investigating

Coverage is 0.7 with maven, so releasing anyway.
@gazbert
Copy link
Owner Author

gazbert commented Mar 3, 2022

Undergoing live testing with exchanges - releasing shortly...

gazbert added a commit that referenced this issue Mar 3, 2022
@gazbert
#143 : Bumped version in prep for next release
5ec1718
gazbert added a commit that referenced this issue Mar 3, 2022
@gazbert
#143 : Fixed README syntax error
dedd89a
@gazbert
Copy link
Owner Author

gazbert commented Mar 4, 2022

Released: https://github.com/gazbert/bxbot/releases/tag/v1.3.0

@gazbert gazbert closed this as completed Mar 4, 2022
@gazbert gazbert unpinned this issue Mar 4, 2022
gazbert added a commit that referenced this issue Mar 7, 2022
@gazbert
#143 : Rename only
d243ca6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gazbert gazbert

Labels
build issue enhancement
Projects
None yet
Milestone
Tech Refresh Release
Development

No branches or pull requests
1 participant
@gazbert