Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

Fixed crash when collision size is zero #2768

Merged
merged 5 commits into from
Jul 9, 2020
Merged

Fixed crash when collision size is zero #2768

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11034c9
Fixed crash when collision size is zero
ahcorde Jun 29, 2020
9c64d55
Added include math.h
ahcorde Jul 3, 2020
1b3e1ee
Using ignition::math::isnan
ahcorde Jul 3, 2020
303bf34
Improved error message
ahcorde Jul 3, 2020
a640b5f
removed include math.h
ahcorde Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions gazebo/rendering/Visual.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -811,9 +811,16 @@ void Visual::SetScale(const ignition::math::Vector3d &_scale)

this->dataPtr->scale = _scale;

this->dataPtr->sceneNode->setScale(
Conversions::Convert(this->dataPtr->scale));

if (!ignition::math::isnan(this->dataPtr->scale.X())
&& !ignition::math::isnan(this->dataPtr->scale.Y())
&& !ignition::math::isnan(this->dataPtr->scale.Z()))
{
this->dataPtr->sceneNode->setScale(
Conversions::Convert(this->dataPtr->scale));
} else {
gzerr << Name() << ": Size of the collision contains one or several zeros." <<
" Collisions may not visualize properly." << std::endl;
}
// Scale selection object in case we have one attached. Other children were
// scaled from UpdateGeomSize
for (auto child : this->dataPtr->children)
Expand Down