Skip to content
This repository has been archived by the owner on Feb 3, 2025. It is now read-only.

SimpleTrackedVehiclePlugin: fix for boost 1.74 (gazebo9) #2865

Merged
merged 1 commit into from
Oct 27, 2020
Merged

SimpleTrackedVehiclePlugin: fix for boost 1.74 (gazebo9) #2865

merged 1 commit into from
Oct 27, 2020

Conversation

scpeters
Copy link
Member

Duplicate of #2862 targeted at gazebo9:

Our macOS builds are failing since homebrew updated to boost 1.74 in Homebrew/homebrew-core#62549:

plugins/SimpleTrackedVehiclePlugin.cc:35:7: error: redefinition of 'hash<boost::shared_ptr<T> >'
class hash<boost::shared_ptr<T>> {
      ^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/local/include/boost/smart_ptr/shared_ptr.hpp:1174:26: note: previous definition is here
template<class T> struct hash< ::boost::shared_ptr<T> >
                         ^

It looks like shared_ptr.hpp has changed in 1.74.0. I've disabled some code in SimpleTrackedVehiclePlugin for boost 1.74 or greater, which seems to fix this.

@scpeters
SimpleTrackedVehiclePlugin: fix for boost 1.74
c2fd34c 
Disable some code in SimpleTrackedVehiclePlugin for boost 1.74
or greater due to changes in boost shared_ptr.hpp

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters added 9 Gazebo 9 build labels Oct 25, 2020
@scpeters scpeters mentioned this pull request Oct 25, 2020
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Oct 26, 2020

@osrf-jenkins retest this please

@scpeters
Copy link
Member Author

test failure are unrelated; merging

@scpeters scpeters merged commit 98e67e6 into gazebosim:gazebo9 Oct 27, 2020
@scpeters scpeters deleted the boost_174_9 branch October 27, 2020 07:30
scpeters added a commit to scpeters/gazebo that referenced this pull request Jan 25, 2021
@scpeters
SimpleTrackedVehiclePlugin: fix for boost 1.74 (gazebosim#2865)
33b6b07 
Disable some code in SimpleTrackedVehiclePlugin for boost 1.74
or greater due to changes in boost shared_ptr.hpp

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters mentioned this pull request Jan 25, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@j-rivero j-rivero j-rivero approved these changes

Assignees
No one assigned
Labels
9 Gazebo 9 build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @ahcorde @j-rivero