Verkle friendly eip2935 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Feb 6, 2024
EIPS/eip-2935.md
Outdated
| Note that this means that slot `max(block.number - 256, 0)` is accessed during block execution. | ||
| At the start of processing any block where `block.timestamp > FORK_TIMESTAMP` (ie. before processing any transactions), | ||
| * run `sstore(HISTORY_STORAGE_ADDRESS, block.number - 1, block.prevhash)`. | ||
| * additionally if this is the first block of the fork, then store last `min(HISTORY_SERVE_WINDOW-1, block.number-1)` blocks' prevhash into their corresponding slots i.e persist the entire `HISTORY_SERVE_WINDOW` block hashes (up until the genesis) that can be accessed in the block. |
There was a problem hiding this comment.
so actually it would need to be min(HISTORY_SERVE_WINDOW, block.number) since the genesis block would have to be inserted as well, and you need to insert all 256 previous blocks at fork block time.
There was a problem hiding this comment.
yes there are additional insert's of last min(HISTORY_SERVE_WINDOW-1, block.number-1) blocks' prevhash
There was a problem hiding this comment.
true, then maybe put "additionally" in bold so that people like me notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates