Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the eip to store in ring buffer instead of serial storage and add eip 158 handling strategy #3

Merged
merged 9 commits into from
Mar 28, 2024

Conversation

g11tech
Copy link

@g11tech g11tech commented Mar 12, 2024

  • Update the eip to store in ring buffer instead of serial storage
  • add eip 158 handling strategy

Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I fixed what I believe are typos. I'll wait for Jochem's feedback before merging.

EIPS/eip-2935.md Outdated Show resolved Hide resolved
EIPS/eip-2935.md Show resolved Hide resolved
EIPS/eip-2935.md Outdated Show resolved Hide resolved
EIPS/eip-2935.md Outdated Show resolved Hide resolved
EIPS/eip-2935.md Outdated Show resolved Hide resolved
EIPS/eip-2935.md Outdated Show resolved Hide resolved
EIPS/eip-2935.md Outdated Show resolved Hide resolved
Copy link

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments :)

EIPS/eip-2935.md Outdated Show resolved Hide resolved
EIPS/eip-2935.md Show resolved Hide resolved
EIPS/eip-2935.md Show resolved Hide resolved
EIPS/eip-2935.md Show resolved Hide resolved
EIPS/eip-2935.md Show resolved Hide resolved
EIPS/eip-2935.md Outdated Show resolved Hide resolved
Copy link

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gballet gballet merged commit 8e3730f into gballet:verkle-friendly-eip2935 Mar 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants