core, trie: cache the code chunking in contract #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
Current state: execution sped up by; a factor 2, and Both functions were called too often, because chunking is performed in |
…als (#122) * core: cache code chunk evaluations to reduce the amount of address evals * fix init bug * fix slicing error that was introduced in previous commits
|
Confirmed improvement |
3 tasks
|
This is still useful when calling CODECOPY, but contract execution is no longer a problem and EXTCODECOPY won't work. I think a better approach is to create a global code cache. I'm creating an issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ChunkifyCodeandtouchEachChunksOnReadAndChargeGasare dominating the execution time, this PR attempts to cache the values as much as possible, in order to reduce the amount of time these functions are called.