Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize overflow after trailer tokens/breaking change tag #63

Closed
ribru17 opened this issue Mar 23, 2024 · 1 comment
Closed

Recognize overflow after trailer tokens/breaking change tag #63

ribru17 opened this issue Mar 23, 2024 · 1 comment

Comments

@ribru17
Copy link
Contributor

ribru17 commented Mar 23, 2024

Hello and thanks for the parser! Just wanted to raise the issue that overflow is not detected for body segments that contain something like BREAKING CHANGE or a generic trailer token. It would be nice if this could work like the regular body segments do. Thank you!
@gbprod
Copy link
Owner

gbprod commented Mar 28, 2024

Interesting, I'll check it soon

gbprod added a commit that referenced this issue Apr 3, 2024
@gbprod
feat: add overflow on trailers
8894e9b 
Ref: #63
@gbprod gbprod mentioned this issue Apr 3, 2024
Merged
gbprod added a commit that referenced this issue Apr 3, 2024
@gbprod
feat: add overflow on trailers (#64)
edd817e 
Ref: #63
@gbprod gbprod closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbprod @ribru17