You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Quite a few operations use vkbeautify to perform their actions. Most of these operations could be done with their own code.
One of the Design Principles of CyberChef is to keep it Standalone and I think that these operations should be rewritten to avoid unnecessarily using the library.
The vkbeautify library is pretty small. Since we use every feature it provides, it seems like a reasonable inclusion. If we were to rewrite each of these operations ourselves, we likely wouldn't actually end up with any less code overall. Obviously we would have more control over it, so I'm not against this, but it's not a high priority at the moment.
I'll close this issue for now, but if anyone would like to submit a PR which replaces vkbeautify with bespoke code, I'll happily take a look at it.
Summary
Quite a few operations use
vkbeautify
to perform their actions. Most of these operations could be done with their own code.One of the Design Principles of CyberChef is to keep it Standalone and I think that these operations should be rewritten to avoid unnecessarily using the library.
Example
The text was updated successfully, but these errors were encountered: