Refactor magicFileType to reduce cyclic dependencies #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucing cyclic dependencies in operations using newly names detectFileType
|
Yeh looks like that covers it! I'll close this then. |
BRAVO68WEB
pushed a commit
to BRAVO68WEB/CyberChef
that referenced
this pull request
May 29, 2022
…lback [FIX] Adds try catch to server welcome msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of an effort to reduce cyclic dependencies, we can refactor magicFileType into a standalone lib file, DetectFileType. This removes cyclic dependencies in the operations that used magicFileType, by removing the import of Magic (which in turn imported Recipe, which imported OpModules, which imported each operation - resulting in our cyclic dependency)
The cyclic dependencies cause issues in generating config for core and node chef. There are still cyclic dependencies in flowcontrol and Magic operations, but they will be addressed in another PR.