Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operation: Defang IP #556

Merged
merged 2 commits into from
Aug 13, 2019
Merged

Operation: Defang IP #556

merged 2 commits into from
Aug 13, 2019

Conversation

h345983745
Copy link
Contributor

@h345983745 h345983745 commented May 12, 2019

A pull request to implement #553.

Example:

Screenshot 2019-05-12 at 15 52 52

Todo:

  • Add tests
  • Move to using lib/IP for regex's.
  • Add to category
  • Remove V4 + V6 Options

Consolidated IP Regex's

Fixed Logic Error

Added Tests

Removed Changes Outside Of Operation

Added to category
@h345983745 h345983745 marked this pull request as ready for review May 12, 2019 20:24
@n1474335
Copy link
Member

This is great. I'd suggest a few changes before we merge it:

  • Import the IP regexes from lib as you mentioned above.
  • Remove the v4 and v6 options. If we're using regexes to specifically search for valid IPs and only defanging those, it's probably just simpler to always defang both types. It keeps things a bit cleaner.

@n1474335
Copy link
Member

Great work, thanks. We still need to make a library class for all the various regular expressions we use all over the place, but that can be in a separate PR.

@h345983745
Copy link
Contributor Author

@n1474335 thanks! I did start to work on moving to using the regex's provided in lib/IP, however I then started to move other operations such as Regular Expression, Extract IP addresses and Group IP Addresses over and found complications so split it out into a separate branch. Will put a PR in once complete.

@h345983745 h345983745 deleted the defang-ip branch August 21, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants