-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Run a recipe over multiple inputs #566
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more elements to be controlled by theme css: - Preloader spinner colours - Operation disable / breakpoint icons - Auto bake checkbox - Search highlight colour - Categories header colour
This can be turned off
Change fonts in solarized themes to match classic. Add styling of input fields to modals
Can add, remove and switch tabs
Allow selecting multiple files. Allow drag and dropping multiple files. Clear all IO button will close all tabs. Will now spawn multiple loaderworkers simultaneously. Improve tab logic to break less and work in Firefox.
Don't show lines value if tab contents is a file.
Limits number of workers to number of cpu threads (4 if not supported) Creates output tabs (switching doesn't work yet) Disabled some highlighting for now.
(This needs some work!)
Output tabs are created when input tabs are. Fix initial bake not working
Don't create a DOM element for every tab, just reuse the same ones. Display file information while the files are loading. (Output tabs no longer work)
Automatically disable auto-bake if more than 20 files are input.
Change some of the HTML around the tab bar
- Will run and display outputs in the output area as they're baked - Creates output tabs - Can change output tabs (only the first 4 at the moment)
Add downloading files as an archive (needs work) Add option for keeping the tabs in sync
Adjust worker logic to avoid closing and reopening a worker as often
Move tab buttons onto tab bar. Calculate size of maxTabs automatically on page load. Display total execution time when a bake finishes.
Move addition of close tab button back
Force wheel event to be not passive. Change maxworkers to be navigator.hardwareConcurrency - 1
Run detectFileType on switched output
n1474335
requested changes
Jun 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff as always. A few things to review here, then it'll be ready to merge.
Use Dish.STRING instead of "string" for get()
Move stepping logic into App. Change toggleBakeButtonFunction to use a str instead of booleans. Tidy up handleLoaderMessage in InputWaiter.
Add comment to inputworker default values.
Debounce bake button function changes.
Tab shadows are now displayed using css classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to load multiple inputs into the web app (#505) , and run a recipe over all of them. I have also made some major changes to the input/output/worker waiters to work with multiple inputs, and have moved a lot of the functionality from the input waiter into a new worker called InputWorker. There are also some improvements to the UI (new themes!)
Multiple inputs
navigator.hardwareConcurrency
value. (Or 4 if this is unavailable).dat
when we can't detect it)Other UI Improvements