Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker login on travis lifecycle, so that is can push images to dockerhub #62

Closed
mdelapenya opened this issue May 25, 2017 · 2 comments
Closed

Add docker login on travis lifecycle, so that is can push images to dockerhub #62

mdelapenya opened this issue May 25, 2017 · 2 comments
Labels
feature
Milestone
alpha-RC2

Comments

@mdelapenya
Copy link
Member

mdelapenya commented May 25, 2017 •
edited
Loading

we must declare env vars on Travis holding the values of DockerHub user and password
@javierlopezdeancos javierlopezdeancos added this to the alpha-RC2 milestone May 25, 2017
mdelapenya added a commit to mdelapenya/katangapp-frontend that referenced this issue May 26, 2017
@mdelapenya
[gdgtoledo#62] Login in docker hub on travis ci
78558a8
@mdelapenya
Copy link
Member Author

Merged, thanks!

image

@mdelapenya
Copy link
Member Author

Reopening as it is not needed for pull requests!

Besides, travis does not have access to env vars in a pull request

@mdelapenya mdelapenya reopened this May 26, 2017
mdelapenya added a commit to mdelapenya/katangapp-frontend that referenced this issue May 26, 2017
@mdelapenya
[gdgtoledo#62] Login to docker hub only on pushes, not on pull requests
fdd15f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
alpha-RC2
Development

No branches or pull requests
2 participants
@mdelapenya @javierlopezdeancos