Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer #2

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Footer #2

wants to merge 2 commits into from

Conversation

KDSgt
Copy link
Collaborator

@KDSgt KDSgt commented Feb 20, 2024

No description provided.

@bj-jiwrajka bj-jiwrajka changed the base branch from main to dev February 21, 2024 06:59
@kherkatary
Copy link
Collaborator

image

Convert all the units to Relative units. px to rem and %, except in media query part

@kherkatary
Copy link
Collaborator

Resolve conflicts

  1. Git pull dev in your branch
  2. Merge and Commit
  3. Again git push

Copy link

netlify bot commented Mar 16, 2024

Deploy Preview for codeshare-client ready!

Name Link
🔨 Latest commit e6416ca
🔍 Latest deploy log https://app.netlify.com/sites/codeshare-client/deploys/65f5d587184013000849d7bd
😎 Deploy Preview https://deploy-preview-2--codeshare-client.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kherkatary
Copy link
Collaborator

kherkatary commented Mar 21, 2024

Fix overlapping issue

footer should not be overlapping other sections

  • dont put positon: fixed
    image

@kherkatary
Copy link
Collaborator

This heading is not similar with the design, use proper heading

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants