Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Issue #2154: Add vagrant-nfs-fix role to fix NFS timeout issues on macOS #2162

Merged
merged 5 commits into from
May 8, 2021

Conversation

oxyc
Copy link
Collaborator

@oxyc oxyc commented May 4, 2021

It's been a long time since I did anything ansible let alone init.d scripts. Therefore this needs reviews.

It's based on the firewall role, with the inital fix from @MokDevelopment and the systemd service by @susannecoates.

  1. Is there an issue running it as root?
  2. Can we somehow detect if the provisioning host is macos?
  3. I'm just using touch since I'm guessing a timestamp modification should be enough? As I type this, I'm just realizing maybe I should add back the rm so the file doesnt accidentally get committed to git on the host.
  4. I dont have diskspace to build any of the RHEL boxes :/ Could someone try it out?
  5. I don't actually see the issue so someone should test it.

Co-authored-by: MokDevelopment
Co-authored-by: Susanne Coates

Copy link
Owner

@geerlingguy geerlingguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, though I think we can ditch the init script as Drupal VM doesn't support any OS version old enough to not have systemd anymore.

default.config.yml Outdated Show resolved Hide resolved
@oxyc
Copy link
Collaborator Author

oxyc commented May 8, 2021

While I have you, it would be much appreciated if you could give geerlingguy/packer-drupal-vm#5 another try at some point! It built successfully for me back when I tried at least.

@geerlingguy geerlingguy merged commit 20b7654 into geerlingguy:master May 8, 2021
@oxyc oxyc deleted the vagrant-fix-nfs branch May 8, 2021 02:27
@marcelovani
Copy link

Had the same issue after upgrading to BigSur. Thanks for the hack to fix it. I wonder how lot its going to take for Vagrant to do a proper fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants