Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address GPAD/GPI spec comments #4703

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Address GPAD/GPI spec comments #4703

merged 1 commit into from
Aug 18, 2023

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Aug 18, 2023

Addressing comments from @kltm:

  • changed GPAD header to use gpad-version
  • simplified Text_No_Spaces definition to avoid only use of complementation in grammar
  • added comments about ISO 8601

@balhoff balhoff requested a review from kltm August 18, 2023 16:55
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@kltm kltm merged commit 61c81fa into master Aug 18, 2023
@balhoff balhoff deleted the balhoff-patch-2 branch August 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants