Misc small identified by preliminary AmiGO integration #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After locally building and packing the latest
wc-gocam-viz
code, I tried bring it into my local AmiGO dev site. That revealed two main sticking points:<script>
tags. Since the legend images we're talking about are actually quite small I've made a change here to simply inline them via rollup's image plugin and avoid Stencil assets altogether. This makes the the bundle a few kB bigger, but it means that downstream clients don't have to do any additional configuration.Other than that these changes remove an unused dependency (
@geneontology/wc-light-modal
) and do a little styling adjustment to prevent overflow in the genes panel when there are more than 4 evidence links to show.