Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api.component.html #26

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Update api.component.html #26

merged 2 commits into from
Jul 12, 2024

Conversation

suzialeksander
Copy link
Contributor

removing sparql link/icon

removing sparql link
@suzialeksander suzialeksander requested a review from kltm July 11, 2024 18:30
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be right, but I don't remember off the top how this CSS works with losing an a-displacement. @dustine32 , I don't suppose you remember for this deploys?

</a>
</li>
<li>
<a href="{{ urlHandler.getAPIDoc() }}" target="blank" class="a-displacement">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suzialeksander I'm wondering if you meant to delete this line:

<a href="{{ urlHandler.getAPIDoc() }}" target="blank" class="a-displacement">

I assume it would break the API endpoint link here:
image
Is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, not intended. thanks for catching that

@dustine32
Copy link
Contributor

@kltm I recall just having to run deploy.sh, maybe piecemeal if any errors occur. I can do this when you are ready.

@suzialeksander
Copy link
Contributor Author

@dustine32 I think I added that line back in. Please merge if OK, and run anything else needed to change this whenever

@dustine32
Copy link
Contributor

@kltm @suzialeksander Thanks! Gonna merge and deploy now.

@dustine32 dustine32 merged commit 94dc34c into master Jul 12, 2024
@dustine32
Copy link
Contributor

@suzialeksander Your change is now deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants