Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the Simulation interface, improve MMS verification, and clean up validation tests #76

Merged
merged 15 commits into from
Jan 21, 2020

Conversation

agzimmerman
Copy link
Member

@agzimmerman agzimmerman commented Jan 17, 2020

Simulation class:

  • Simplified interface. Before, there was a pattern where many parameters were set with init while others were assigned after instantiation. Parameters can still be assigned after instantiation, but the default pattern now is to include all parameters also as arguments to init. This cleans up a lot of the test/user code.
  • Handle solver parameters in the same way as other parameters, starting as an argument to init. Before, it was more complicated to understand which solver parameters were being used when using sub classes which redefined the parameters by redefining the solve method.

MMS module:

  • Verify accuracy of each solution subspace separately; remove mixed error norm.
  • Report mesh cell count and function space DOF count.
  • Expose the strong form and Dirichlet BC's as arguments so that the defaults can be overridden, though only the defaults are currently being tested.
  • Updated many verification tests to check H1 norm instead of L2 norm
  • Simplified interface for passing simulation keyword arguments

Convection-coupled phase-change simulation class:

  • Make the element more general, e.g. allowing easy use of Taylor-Hood style elements
  • Update verification tests to use H1 norm for velocity and temperature
  • Report mean pressure and velocity divergence.
  • Simplified some interfaces, allowing more parameters to be passed as argument rather than having to use assign after init.
  • More descriptive names for liquid smoothing parameter and pressure penalty factor.
  • Removed some artifacts from the validation tests, making them much more readable.

Alexander G. Zimmerman added 10 commits January 17, 2020 13:48
…hoose norms in MMS verification, use correct norms for velocity and temperature throughout verification tests
…actually change the pressure error issue. Revert some previous changes in the manufactured solution. Increase gamma so pressure error magnitude is lower
…s it easier to configure solver parameters
@agzimmerman agzimmerman changed the title Update verification tests to use H1 norm where appropriate Simplify interface and improve verification Jan 18, 2020
@agzimmerman agzimmerman changed the title Simplify interface and improve verification Simplify interfaces and improve verification Jan 18, 2020
Alexander G. Zimmerman added 5 commits January 18, 2020 16:05
@agzimmerman agzimmerman changed the title Simplify interfaces and improve verification Simplify the Simulation interface, improve MMS verification, and clean up validation tests Jan 21, 2020
@agzimmerman agzimmerman merged commit 5148078 into master Jan 21, 2020
@agzimmerman agzimmerman deleted the paper/taylorhood_pressurepenalty_andh1norm branch January 21, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant