-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the Simulation interface, improve MMS verification, and clean up validation tests #76
Merged
agzimmerman
merged 15 commits into
master
from
paper/taylorhood_pressurepenalty_andh1norm
Jan 21, 2020
Merged
Simplify the Simulation interface, improve MMS verification, and clean up validation tests #76
agzimmerman
merged 15 commits into
master
from
paper/taylorhood_pressurepenalty_andh1norm
Jan 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hoose norms in MMS verification, use correct norms for velocity and temperature throughout verification tests
…actually change the pressure error issue. Revert some previous changes in the manufactured solution. Increase gamma so pressure error magnitude is lower
…t doesn't need to be raised
…s it easier to configure solver parameters
agzimmerman
changed the title
Update verification tests to use H1 norm where appropriate
Simplify interface and improve verification
Jan 18, 2020
agzimmerman
changed the title
Simplify interface and improve verification
Simplify interfaces and improve verification
Jan 18, 2020
…up from submitted paper, i.e. without using the top wall heat flux
…ugh looking at heat fluxes for both the top and bottom walls might be interesting in light of the submitted paper
agzimmerman
changed the title
Simplify interfaces and improve verification
Simplify the Simulation interface, improve MMS verification, and clean up validation tests
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simulation class:
MMS module:
Convection-coupled phase-change simulation class:
assign
after init.