Generate JSONs with Jbuilder #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
Define a brand new Liquid tag for templating JSONs with Jbuilder.
The output is the same, but logic is readable and free of Liquid quirks.
| end | ||
|
|
||
| # Displays line that the error has occurred at. | ||
| def location_surroundings(before: 2, after: 2) |
There was a problem hiding this comment.
Assignment Branch Condition size for location_surroundings is too high. [21.38/15]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings Jbuilder, a Ruby DSL for structuring JSONs, into Geolexica.
Templating JSONs with Liquid is a poor idea for many reasons. Templates are difficult to read, it's easy to introduce errors, processing them is slow. Switching to Jbuilder solves all these problems.
A brand new
{% jbuilder %}Liquid block tag is introduced. Content between that and a corresponding closing tag is captured and evaluated as a piece of Jbuilder-powered Ruby script, then a resulting JSON is rendered in place of that block. Rendering context (including page's front matter) is exposed through a getter. Because JSON-building Ruby script is still enclosed in a template, it's easy to override it in particular sites if needed.All the JSONs defined in this gem have been rewritten in a Jbuilder fashion. JSONs defined in sites require separate treatment.
A side benefit is that sites generate noticeably faster (up to 30% as observed on my computer).