updated to use glossarist models for concept and managed_concept #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| module Termbase | ||
| module Glossarist | ||
| class Concept < ::Glossarist::LocalizedConcept | ||
| attr_accessor :status, :dateAccepted |
| data_hash.merge(register_info) | ||
| end | ||
|
|
||
| def register_info |
There was a problem hiding this comment.
Cyclomatic complexity for register_info is too high. [7/6]
ronaldtse
approved these changes
Mar 4, 2024
|
Thanks @HassanAkbar , can you please help release the gem, and use the new gem to update https://github.com/geolexica/isotc211-glossary ? In: |
HassanAkbar
deleted the
updating_to_use_glossarist_for_concept_generation
branch
|
@ronaldtse Version |
@ronaldtse I've already updated the glossary in geolexica/isotc211-glossary#47 using the branch for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using custom
conceptandmanaged_conceptmodels to add register info to generated concepts.