Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency in requirements-dev.txt #254

Merged

Conversation

jtmiclat
Copy link
Contributor

Hi i cloned the repo and tried running the following to run the tests

pip install -e .
pip install -r requirements-dev.txt 

but when i was running the test i hit the following error

❯ pytest dask_geopandas/tests
ERROR collecting dask_geopandas/tests/test_geohash.py _______________________________________________________________________________
ImportError while importing test module '/Users/jtmiclat/personal/dask-geopandas/dask_geopandas/tests/test_geohash.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../.pyenv/versions/3.9.16/lib/python3.9/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
dask_geopandas/tests/test_geohash.py:6: in <module>
    from pygeohash import encode
E   ModuleNotFoundError: No module named 'pygeohash' 

Baed on

# test dependencies
- pytest
- pytest-cov
- hilbertcurve
- pygeohash
- pip
- pip:
- pymorton

requirements-dev.txt was missing pygeohash. After adding it to the requirments-dev.txt the test ran correctly

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis martinfleis merged commit 2d0abad into geopandas:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants