This repository has been archived by the owner on Nov 12, 2023. It is now read-only.
Upgrade to arrow2 v0.17 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kylebarron I just saw this is awaiting approval to run CI - any reasons for this or did it just go unnoticed? |
|
oh whoops I did not see this PR, sorry! |
|
No worries ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kyle,
I used this crate but required a more current version of
arrow2, so I did the migration and decided a PR may be helpful.The main changes are related to the
slicemethod now modifying the array itself instead of returning a cloned array (jorgecarleitao/arrow2#1396), and the newly introducedOffset::len_proxymethod (jorgecarleitao/arrow2#1330).Please review carefully - I tried to adapt all doc-strings - hopefully I missed none.