Use JVN_ as max not exact number of J-values

[lizziel]

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR updates how global variable JVN_ is used. It is described in the code as maximum number of J-values but was used instead as the exact number of J-values by setting the maximum index of FJX_j2j.dat entries read. This set up the possibility of a silent bug if FJX_j2j.dat was expanded but JVN_ remained the same.

This update introduces new behavior where JVN_ is set to a high number beyond the number of entries in FJX_j2j.dat. File read of FJX_j2j.dat stops when 9999 is encountered at the start of a line. Previously FJX_j2j.dat files ended in 9999 so inclusion of that in the file is not new.

Besides preventing the silent bug described above this update is beneficial by enabling removal of model-dependent C-preprocessor blocks where JVN_ values were set. Those values would need to be updated every time new photolysis reactions were added to external models. A drawback of this update, however, is that several arrays are allocated more memory than they need. However, the arrays are 1D and relatively small so this should not make a significant impact.

Expected changes

This is a zero diff update.

Reference(s)

None

Related Github Issues and PRs

None