Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iframe on react quill textarea #2605

Closed
allyoucanmap opened this issue Feb 14, 2018 · 4 comments · Fixed by #2641
Closed

Improve iframe on react quill textarea #2605

allyoucanmap opened this issue Feb 14, 2018 · 4 comments · Fixed by #2641

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Feb 14, 2018

Description

Improve iframe functionality to react quill editor.
Currently the react quill editor uses an iframe component to display video, without the possibility to change width or height of the component.
The aim of this issue is to add a module to react-quill that enable the edit of resize and src of iframes.

This functionality could be useful on get feature template where it's possible to make a iframe view based on one or more variables.

Other useful information (optional):

@allyoucanmap allyoucanmap added this to the 2018.02.00 (Style Editor) milestone Feb 14, 2018
@allyoucanmap allyoucanmap self-assigned this Feb 14, 2018
@mbarto
Copy link
Contributor

mbarto commented Feb 14, 2018

Can you explain a little better why it is useful to have an iframe and how would you use it?

@allyoucanmap
Copy link
Contributor Author

@mbarto
Yes, I just updated the description with a better explanation

@allyoucanmap allyoucanmap changed the title Add iframe on react quill textarea Improve iframe on react quill textarea Feb 26, 2018
mbarto pushed a commit that referenced this issue Mar 12, 2018
* Added resize module on quill editor

* Added tests

* Removed current test path

* Updated doc and icon option

* Removed icon

* Added new tests

* Set default iframeIcon to true

* Fix ql video innerHTML
@ghost ghost removed In Test review labels Mar 12, 2018
@chiaracurcio chiaracurcio self-assigned this Mar 15, 2018
@georgepoulos
Copy link

I try to compile MapStore2 today and there is problem with Quill.
When i create a save a chart. It has no frame when is saved on map,
and a second problem is selected layers properties are not working

quill

Overwriting formats/video with

IFrame() ​blotName: "video" ​className: "ql-video" ​create: function create() ​formats: function formats() ​length: 0 ​name: "IFrame" ​prototype: Object { … } ​sanitize: function sanitize() ​tagName: "DIV" ​value: function value() ​__proto__: function Embed()

@allyoucanmap
Copy link
Contributor Author

Hi @georgepoulos,
could you move the discussion on the mailing list and send us more details?

When i create a save a chart. It has no frame when is saved on map

could you please send a screentshoot of chart saved without frame on map ?

and a second problem is selected layers properties are not working

this is issue seems related to #2759
now property plugin need to be configured

add TOCItemsSettings to plugins.js

TOCItemsSettingsPlugin: require('path-to-plugin-folder/TOCItemsSettings')

and to localConfig.json:
desktop

"TOCItemsSettings"

mobile

{
    "name": "TOCItemsSettings",
    "cfg": {
        "width": 300
    }
}

I try to compile MapStore2 today and there is problem with Quill.

The warning message is due to an override of video functionality to extend the ability to edit iframe on quill textarea and shouldn't cause issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants