Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After login on public map you can not save #3385

Closed
offtherailz opened this issue Nov 30, 2018 · 2 comments · Fixed by #3730 or #3757
Closed

After login on public map you can not save #3385

offtherailz opened this issue Nov 30, 2018 · 2 comments · Fixed by #3730 or #3757
Assignees
@offtherailz @kappu72 @gioscarda
Labels
Accepted bug Priority: High
Milestone
2019.01.01

Comments

@offtherailz
Copy link
Member

offtherailz commented Nov 30, 2018 •
edited
Loading

Description

If you open an existing map and login, you can not see the "Save" button, only "Save as". This because mapInfo are not reloaded.

In case of Bug (otherwise remove this paragraph)

Browser Affected
any

Steps to reproduce

  • Open a map
  • login as owner or admin
  • Open burger menu

Expected Result

  • I have save button

Current Result

  • save button is missing (only save as). If you refresh or go back and than open again the map, the save button disappears.

Other useful information (optional):

This issue is related to #1993 , probably the same cause ( mapInfo not reloaded ).
@offtherailz offtherailz added this to the 2019.01.00 milestone Nov 30, 2018
@tdipisa tdipisa modified the milestones: 2019.01.00, 2019.01.01 Dec 19, 2018
@tdipisa tdipisa mentioned this issue Mar 14, 2019
Closed
4 tasks
@tdipisa tdipisa added ready and removed backlog labels Mar 15, 2019
@tdipisa tdipisa assigned kappu72 and unassigned allyoucanmap May 3, 2019
@kappu72 kappu72 mentioned this issue May 7, 2019
Closed
12 tasks
kappu72 added a commit to kappu72/MapStore2 that referenced this issue May 7, 2019
@kappu72
Closes geosolutions-it#3385
3cbcf62
@kappu72 kappu72 mentioned this issue May 7, 2019
Merged
12 tasks
@ghost ghost added pending review review and removed ready labels May 7, 2019
offtherailz pushed a commit that referenced this issue May 9, 2019
@kappu72 @offtherailz
Fix #3385 fix missing save button after login (#3730)
27f0704
kappu72 added a commit to kappu72/MapStore2 that referenced this issue May 10, 2019
@kappu72
Fix geosolutions-it#3385 fix missing save button after login (geosolu…
83c5ab5 
…tions-it#3730)

(cherry picked from commit 27f0704)
@kappu72 kappu72 mentioned this issue May 10, 2019
Merged
12 tasks
offtherailz pushed a commit that referenced this issue May 13, 2019
@kappu72 @offtherailz
Fix #3385 fix missing save button after login (#3730) (#3747)
8c38425 
(cherry picked from commit 27f0704)
@tdipisa tdipisa reopened this May 14, 2019
@gioscarda gioscarda self-assigned this May 15, 2019
@gioscarda
Copy link
Contributor

gioscarda commented May 15, 2019 •
edited
Loading

The problem does not seem to have been solved (both on DEV and QA).
I tried the following steps:

  • open a map without login --> neither 'SAVE' nor 'SAVE AS' displayed
    image.png
  • login as admin --> only the 'SAVE AS' button displayed
    image.png
  • refresh --> 'SAVE' and 'SAVE AS' buttons all visible
    image.png

@kappu72
Copy link
Contributor

kappu72 commented May 15, 2019

The request is thrown but the Save plugin selector isn't updated if the user is admin.
I'll check

kappu72 added a commit to kappu72/MapStore2 that referenced this issue May 15, 2019
@kappu72
Close geosolutions-it#3385 the mapId in loadMapInfo action needs to b…
e1fc753 
…e a string otherwise the reducers doesn't update the map state
@kappu72 kappu72 mentioned this issue May 15, 2019
Merged
12 tasks
offtherailz pushed a commit that referenced this issue May 16, 2019
@kappu72 @offtherailz
Close #3385 Close missing save button after login (#3757)
c1f3cca
@gioscarda gioscarda reopened this May 16, 2019
offtherailz pushed a commit to offtherailz/MapStore2 that referenced this issue May 16, 2019
@kappu72 @offtherailz
Close geosolutions-it#3385 Close missing save button after login (geo…
9c3a5a7 
…solutions-it#3757)
@ghost ghost assigned offtherailz May 16, 2019
@offtherailz offtherailz reopened this May 16, 2019
offtherailz added a commit that referenced this issue May 16, 2019
@offtherailz
Close #3385 Close missing save button after login (#3757) (#3761)
abc2cc0
kappu72 added a commit to kappu72/MapStore2 that referenced this issue May 17, 2019
@kappu72
Close geosolutions-it#3385 Close missing save button after login (geo…
e0088c5 
…solutions-it#3757)

(cherry picked from commit c1f3cca)
kappu72 added a commit to kappu72/MapStore2 that referenced this issue May 17, 2019
@kappu72
Close geosolutions-it#3385 backport to 2019.xx
e02161b
@kappu72 kappu72 mentioned this issue May 17, 2019
Merged
12 tasks
offtherailz pushed a commit that referenced this issue May 17, 2019
@kappu72 @offtherailz
Backport #3385 Fix missing save button after login (#3757) (#3762)
7576e94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@offtherailz offtherailz

@kappu72 kappu72

@gioscarda gioscarda

Labels
Accepted bug Priority: High
Projects
None yet
Milestone
2019.01.01
5 participants
@offtherailz @tdipisa @kappu72 @allyoucanmap @gioscarda