Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer properties are not accessible if its style is invalid #3415

Closed
4 tasks
allyoucanmap opened this issue Dec 18, 2018 · 2 comments · Fixed by #3719
Closed
4 tasks

Layer properties are not accessible if its style is invalid #3415

allyoucanmap opened this issue Dec 18, 2018 · 2 comments · Fixed by #3719

Comments

@allyoucanmap
Copy link
Contributor

Description

In some cases styles are created and updated correctly but when apply to the layer return an exception.
If GetMap has exception TOCItemSettings is not accessible and the style parameters can't be changed.

  • Following style cause the issue
@styleTitle 'Solid fill';
@styleAbstract '';

[this_is_not_a_param = 'a'] {
	fill: #aaaaaa;
}

In case of Bug (otherwise remove this paragraph)

Browser Affected
(use this site: https://www.whatsmybrowser.org/ for non expert users)

  • Internet Explorer
  • Chrome
  • Firefox
  • Safari

Browser Version Affected

  • all

Steps to reproduce

  • open a map with vector layer
  • select the layer and open the settings of layer
  • select style tab
  • create a new style and edit it
  • write the style* that cause the error

Expected Result

  • There should be a way to access the parameters to update the layer parameters or at least reset the layer parameters to ensure that the error depends on wrong paramaters

Current Result

  • Layer parameters can't be chaged and settings aren't accessible

Other useful information (optional):

@tdipisa tdipisa added this to the 2019.01.00 milestone Dec 18, 2018
@tdipisa tdipisa modified the milestones: 2019.01.00, 2019.01.01 Dec 19, 2018
@ghost ghost added pending review review and removed ready labels May 6, 2019
tdipisa pushed a commit that referenced this issue May 6, 2019
…#3719)

* enabled settings on layer with error

* add documentation for get status
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue May 6, 2019
…tyle is invalid (geosolutions-it#3719)

* enabled settings on layer with error

* add documentation for get status
@tdipisa tdipisa reopened this May 14, 2019
@gioscarda
Copy link
Contributor

I've tried it on geonode with the states layer.
I've created a new CSS style for this layer and then I edit it as suggested by @allyoucanmap.

The CSS style name is My style.

The style has been saved without errors, I returned back and saved the changes with the save button. After that the TOC appears like this:

image.png

So the layers settings are available but when I try to re-edit the style its name is changed in Solid fill:
image.png

Is this acceptable?

@gioscarda gioscarda self-assigned this May 17, 2019
@gioscarda gioscarda reopened this May 20, 2019
@gioscarda
Copy link
Contributor

gioscarda commented May 20, 2019

The MS2 behaviour described in the previous comment is related to the geonode integration only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment