Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid request to printUrl if print plugin is absent #3682

Closed
MV88 opened this issue Apr 9, 2019 · 0 comments · Fixed by #3683
Closed

avoid request to printUrl if print plugin is absent #3682

MV88 opened this issue Apr 9, 2019 · 0 comments · Fixed by #3683
Assignees
@MV88 @gioscarda
Labels
Accepted Priority: High Project: C098
Milestone
2019.02.00

Comments

@MV88
Copy link
Contributor

MV88 commented Apr 9, 2019

Description

in custom project you cannot remove the the request to printUrl
see here

In case of Bug (otherwise remove this paragraph)

Browser Affected
(use this site: https://www.whatsmybrowser.org/ for non expert users)
any
Browser Version Affected

Steps to reproduce

  • cannot testable,
  • configure a local project and remvoe print plugin from local config and from plugins, then you alwyas see the reuest to pdf/info.json

Expected Result

being able to avoid that
avoid passing here

Current Result

it does always the request

Other useful information (optional):
@MV88 MV88 added this to the 2019.02.00 milestone Apr 9, 2019
@MV88 MV88 self-assigned this Apr 9, 2019
MV88 added a commit to MV88/MapStore2 that referenced this issue Apr 9, 2019
@MV88
Fix geosolutions-it#3682 request to printUrl
08d2704
@MV88 MV88 mentioned this issue Apr 9, 2019
Merged
12 tasks
@MV88 MV88 closed this as completed in #3683 Apr 9, 2019
MV88 added a commit that referenced this issue Apr 9, 2019
@MV88
Fix #3682 request to printUrl (#3683)
716b6c7 
* Fix #3682 request to printUrl

* add test for printingEnabled False

* clean up main.js code
@MV88 MV88 removed the 1 Point label Apr 11, 2019
@tdipisa tdipisa reopened this May 14, 2019
@gioscarda gioscarda self-assigned this Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MV88 MV88

@gioscarda gioscarda

Labels
Accepted Priority: High Project: C098
Projects
None yet
Milestone
2019.02.00
Development

Successfully merging a pull request may close this issue.

Fix #3682 request to printUrl MV88/MapStore2
3 participants
@tdipisa @MV88 @gioscarda