Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10193: Issue with WFS added via Query params #10195

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

In this PR, the issue of not adding WFS layer to map and be not visible is resolved. GetFeature request is performed now correctly by MS.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10193

What is the current behavior?
#10193

What is the new behavior?
WFS layer is added to map using query params in url if the url contains queryString.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge
@mahmoudadel54 mahmoudadel54 self-assigned this Apr 12, 2024
@mahmoudadel54 mahmoudadel54 linked an issue Apr 12, 2024 that may be closed by this pull request
1 task
@tdipisa tdipisa modified the milestones: 2024.01.00, 2024.01.01 Apr 15, 2024
@tdipisa tdipisa requested review from dsuren1 and removed request for allyoucanmap April 15, 2024 08:50
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Apr 15, 2024
web/client/api/WFS.js Outdated Show resolved Hide resolved
@dsuren1 dsuren1 enabled auto-merge (squash) April 15, 2024 12:36
@dsuren1 dsuren1 merged commit e6d1789 into geosolutions-it:master Apr 15, 2024
5 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented Apr 16, 2024

@ElenaGallo Kindly test it in DEV and let us know if it can be backported. Thanks!

@tdipisa
Copy link
Member

tdipisa commented Apr 16, 2024

@ElenaGallo @mahmoudadel54 this is for 2024.01.01 therefore let's wait the delivery of 2024.01.00 before backporting this. Thank you.

@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request May 9, 2024
…tions-it#10195)

* geosolutions-it#10193: Issue with WFS added via Query params
- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge

* Update web/client/api/WFS.js

---------

Co-authored-by: Suren <[email protected]>
@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks
@ElenaGallo
Backport is Done here ---> #10296

tdipisa pushed a commit that referenced this pull request May 10, 2024
* #10193: Issue with WFS added via Query params
- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge

* Update web/client/api/WFS.js

---------

Co-authored-by: Suren <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with WFS added via Query params
4 participants