-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10193: Issue with WFS added via Query params #10195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the issue behind not adding the wfs layer - write the unit tests for this cahnge
1 task
tdipisa
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Apr 15, 2024
dsuren1
requested changes
Apr 15, 2024
dsuren1
approved these changes
Apr 15, 2024
@ElenaGallo Kindly test it in DEV and let us know if it can be backported. Thanks! |
@ElenaGallo @mahmoudadel54 this is for 2024.01.01 therefore let's wait the delivery of 2024.01.00 before backporting this. Thank you. |
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 9, 2024
…tions-it#10195) * geosolutions-it#10193: Issue with WFS added via Query params - fix the issue behind not adding the wfs layer - write the unit tests for this cahnge * Update web/client/api/WFS.js --------- Co-authored-by: Suren <[email protected]>
|
tdipisa
pushed a commit
that referenced
this pull request
May 10, 2024
* #10193: Issue with WFS added via Query params - fix the issue behind not adding the wfs layer - write the unit tests for this cahnge * Update web/client/api/WFS.js --------- Co-authored-by: Suren <[email protected]>
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the issue of not adding WFS layer to map and be not visible is resolved. GetFeature request is performed now correctly by MS.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10193
What is the current behavior?
#10193
What is the new behavior?
WFS layer is added to map using query params in url if the url contains queryString.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information