-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10272: Choice of OGC service type for single layer in CSW catalog #10304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuren1
added
enhancement
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
C027-COMUNE_FI-2023-SUPPORT
labels
May 10, 2024
MV88
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of comments with some jsdoc
MV88
approved these changes
May 16, 2024
@ElenaGallo please test in DEV |
Test passed, @dsuren1 please backport to 2024.01.xx. Thanks |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
May 16, 2024
… CSW catalog (geosolutions-it#10304) (cherry picked from commit d033bc7)
MV88
pushed a commit
that referenced
this pull request
May 16, 2024
ElenaGallo
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives the ability for the user to choose which service type, when the records has support for multi OGC service in the dc references, to be used when adding a layer to map via catalog of service type 'csw'
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
User can choose the service from which the layer to be added to Map.
Note
Currently support only WFS as the additional OGC service
wfs_csw.mp4
Note
TEST DATA
https://gn3-rndt.geo-solutions.it/geonetwork/srv/eng/csw (Layer name - unesco)
https://geobretagne.fr/geonetwork/srv/fre/csw (many records has multiple ogc service)
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information