Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10308: Disable the marker when the search for map type is changed #10316

Merged
merged 1 commit into from
May 16, 2024

Conversation

mahmoudadel54
Copy link
Contributor

Description

In this PR, clearing marker of coords search if switching from coord search to bookmark search is implemented.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#10308

What is the current behavior?
#10308

What is the new behavior?
If user makes a coord search [lat/lon] or [X/Y] and shows a marker of his/her search, then he/she switches to bookmark search, the marker will be removed from map.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…e is changed

Description:
- handle clearing marker of coords search if switching from coord search to bookmark search
@mahmoudadel54 mahmoudadel54 added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C277-REGION_DE_MURCIA-2024-SUPPORT labels May 14, 2024
@mahmoudadel54 mahmoudadel54 added this to the 2024.01.01 milestone May 14, 2024
@mahmoudadel54 mahmoudadel54 requested a review from dsuren1 May 14, 2024 12:20
@mahmoudadel54 mahmoudadel54 self-assigned this May 14, 2024
@mahmoudadel54 mahmoudadel54 linked an issue May 14, 2024 that may be closed by this pull request
1 task
@dsuren1 dsuren1 merged commit db4d9a4 into geosolutions-it:master May 16, 2024
6 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented May 16, 2024

@ElenaGallo Kindly test this fix in DEV and let us know if it's good to be backported. Thanks!

@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request May 17, 2024
…e is changed (geosolutions-it#10316)

Description:
- handle clearing marker of coords search if switching from coord search to bookmark search
@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks

Backport is done ---> #10336

dsuren1 pushed a commit that referenced this pull request May 17, 2024
…10316) (#10336)

Description:
- handle clearing marker of coords search if switching from coord search to bookmark search
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable the marker when the search for map type is changed
3 participants