Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider queryable layers when 'enableInfoForSelectedLayers' is off and a selected layer is disabled #10377

Merged

Conversation

tha-nordiq
Copy link
Contributor

Description

enableInfoForSelectedLayers: false is a config option to disregard selection for identify . But when there are queryable layers and a switched off layer is selected, the "No active queryable layer" popup is shown.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
When there are queryable layers and a switched off layer is selected, the "No active queryable layer" popup is shown.

What is the new behavior?
When there are queryable layers and a switched off layer is selected, the queryable layers are queried.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

tested with this localConfig item

      {
        "name": "Identify",
        "cfg": {
          "showHighlightFeatureButton": true,
          "showAllResponses": false,
          "enableInfoForSelectedLayers": false,
          "viewerOptions": {
            "container": "{context.ReactSwipe}"
          },
          "showEdit": true
        },
        "override": {
          "Toolbar": {
            "position": 11
          }
        }
      }

@tdipisa tdipisa requested a review from dsuren1 May 29, 2024 14:50
@tdipisa tdipisa added this to the 2024.01.02 milestone May 29, 2024
@dsuren1 dsuren1 changed the title Selected layers should not be considered when "enableInfoForSelectedlayers" is off Consider queryable layers when 'enableInfoForSelectedLayers' is off and a selected layer is disabled May 30, 2024
@dsuren1 dsuren1 enabled auto-merge (squash) May 30, 2024 06:17
@dsuren1
Copy link
Contributor

dsuren1 commented May 30, 2024

@tha-nordiq Thanks for the contribution

@dsuren1 dsuren1 added the bug label May 30, 2024
@dsuren1 dsuren1 merged commit 4f33e39 into geosolutions-it:master May 30, 2024
5 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented May 30, 2024

@ElenaGallo Kindly test this fix in DEV. Thanks!

@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 30, 2024
@tdipisa tdipisa modified the milestones: 2024.01.02, 2024.01.01 May 30, 2024
@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2024.01.xx. Thanks

dsuren1 pushed a commit to dsuren1/MapStore2 that referenced this pull request May 30, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 30, 2024
@tdipisa
Copy link
Member

tdipisa commented May 30, 2024

@tha-nordiq thank you so much for your contribution. the fix will be present in the next upcoming minor release.

tdipisa pushed a commit that referenced this pull request May 30, 2024
…ayers" is off (#10377) (#10381)

(cherry picked from commit 4f33e39)

Co-authored-by: Thomas Hallundbæk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants