Fix #1737 Query panel search fails if an id is not defined #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allyoucanmap
commented
May 8, 2017
allyoucanmap
commented
- Added epic to handle WFS id error on query and forced sort on the first attribute.
- Removed thunk query from WFS action
- Added wfs query documentation
offtherailz
requested changes
May 9, 2017
web/client/epics/wfsquery.js
Outdated
| /** | ||
| * Sends a WFS query, returns a response or handles request error | ||
| * in particular the NoApplicableCode WFS error with a forced sort option on the first attribute | ||
| * @param {Observable} action$ manages `QUERY` |
There was a problem hiding this comment.
external:Observable see other epics.
web/client/epics/wfsquery.js
Outdated
| Rx.Observable.of(createQuery(action.searchUrl, action.filterObj)), | ||
| Rx.Observable.of(setControlProperty('drawer', 'enabled', false)), | ||
| getWFSFeature(action.searchUrl, action.filterObj) | ||
| .switchMap((response) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.