Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another fix for the plugins example #2595

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

mbarto
Copy link
Contributor

@mbarto mbarto commented Feb 9, 2018

Description

Included standard epics

Issues

  • Fix plugins example not including standard epics

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
plugins example not including standard epics

What is the new behavior?
plugins example including standard epics

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix lint before merge

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 80.699% when pulling 58f5da6 on mbarto:plugins_example_fixes into 6416f23 on geosolutions-it:master.

@mbarto mbarto merged commit 88ce465 into geosolutions-it:master Feb 13, 2018
@chiaracurcio chiaracurcio self-assigned this Feb 15, 2018
@chiaracurcio chiaracurcio removed their assignment Feb 15, 2018
@offtherailz offtherailz mentioned this pull request Mar 7, 2018
10 tasks
offtherailz pushed a commit that referenced this pull request Mar 7, 2018
* Another fix for the plugins example

* Fixes for lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants