Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow animation disable to support vertical toolbars #2693

Merged
merged 3 commits into from
Mar 12, 2018

Conversation

offtherailz
Copy link
Member

Description

Bootstrap manages vertical toolbars using a css rule with ">".
Current misc/Toolbar component introduces ReactCSSAnimationGroup inside the toolbar, that produces an internal span element. This difference make the css rules for vertical toolbar not valid.

This pull requests make the animation group optional for this reason.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)

  • Vertical toolbars do not work (no vertical toolbar is present)

What is the new behavior?

  • Now devs have a way to create vertical toolbar as usual (reading the doc)

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

@ghost ghost removed the pending review label Mar 5, 2018
@coveralls
Copy link

coveralls commented Mar 5, 2018

Coverage Status

Coverage increased (+0.001%) to 80.498% when pulling 9b7f227 on offtherailz:v_toolbars into ebb2dd1 on geosolutions-it:master.

@offtherailz offtherailz requested a review from allyoucanmap March 9, 2018 16:57
@mbarto mbarto merged commit 8f3eb98 into geosolutions-it:master Mar 12, 2018
@ghost ghost removed In Test review labels Mar 12, 2018
@offtherailz
Copy link
Member Author

During latest developments a vertical toolbar has been created.
For testing now you can simply check if the vertical toolbar of the dashboard (on the left) is correctly aligned in vertical
Steps to reproduce

  • Open Geodashboard
  • Check if the buttons on the left are correctly aligned vertically.

Note: during development the button number may change.

@offtherailz offtherailz deleted the v_toolbars branch May 26, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants