Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2602 #2735

Closed
wants to merge 8 commits into from
Closed

Issue #2602 #2735

wants to merge 8 commits into from

Conversation

amusso01
Copy link
Contributor

Description

Correct the opacity of the loader of the dialog box to display it on loading

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
While uploading local vector loader doesn't appear

What is the new behavior?
Loader appear inside the dialog box on local vector uploading

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

@ghost ghost removed the pending review label Mar 13, 2018
@mbarto
Copy link
Contributor

mbarto commented Mar 13, 2018

I think you are including commits from another PR. You should create a new branch from master each time you start to work on a new issue.

@MV88
Copy link
Contributor

MV88 commented Mar 13, 2018

also don't forget to run git pull before doing the new branch from master :)

@geosolutions-it geosolutions-it deleted a comment Mar 13, 2018
@amusso01
Copy link
Contributor Author

Ok got it. Thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 80.367% when pulling aef9239 on amusso01:issue_2602 into 5fe67f5 on geosolutions-it:master.

@amusso01 amusso01 closed this Mar 13, 2018
@ghost ghost removed In Test review labels Mar 13, 2018
@chiaracurcio chiaracurcio changed the title Issue 2602 Issue #2602 Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading spinner on import of local vector
5 participants