Fix #3642 Switch between widgets and timeline #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor of selectors to identify show and data presence conditions
ghost
assigned 
- Moved the timeline above the widgets to avoid timelines settings panel to overlap pinned widgets - Show tooltip only when collapsed
allyoucanmap
approved these changes
Apr 19, 2019
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
May 3, 2019
tdipisa
pushed a commit
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request add the following features :
When widgets and timeline are on the same map, only one will be visible at the same time.
The user can use the widgets tray to switch between timeline or widgets.
When the timeline or the widgets are collapsed automatically (due to a widget add or time layer add) a notification explains what happened and how to use it (notifications are triggered only once). A tooltip highlight the timeline button the timeline button when collapsed.
Layout has been a little adjusted to uniform the timeline with widgets margins
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
Widgets and Timeline overlap
What is the new behavior?
Widgets and timeline do not overlap anymore.
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: