Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3534 No result on one content tab cause switch to the other tab (maps/dashboards) #3733

Merged
merged 3 commits into from
May 9, 2019
Merged

Closes #3534 No result on one content tab cause switch to the other tab (maps/dashboards) #3733

merged 3 commits into from
May 9, 2019

Conversation

kappu72
Copy link
Contributor

@kappu72 kappu72 commented May 8, 2019

Description

ContentTabs switch correctly between maps and dashboards when reloaded.

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
ContentTabs doesn't automatically switch to content with elements if the current content hasn't.

What is the new behavior?
ContTabs switch to first content with elements if the current hasn't

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@ghost ghost assigned kappu72 May 8, 2019
@kappu72 kappu72 added this to the 2019.01.01 milestone May 8, 2019
@coveralls
Copy link

coveralls commented May 8, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 81.375% when pulling 8c6c9a9 on kappu72:issue#3534 into d3a2a2a on geosolutions-it:master.

@kappu72 kappu72 closed this May 8, 2019
@kappu72 kappu72 reopened this May 8, 2019
@ghost ghost assigned offtherailz May 9, 2019
offtherailz
offtherailz approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indentation notes.

@offtherailz offtherailz changed the title Closes #3534 Closes #3534 Switch to maps or dashboards tab when 0 result May 9, 2019
@offtherailz offtherailz changed the title Closes #3534 Switch to maps or dashboards tab when 0 result Closes #3534 No result on one content tab cause switch to the other tab (maps/dashboards) May 9, 2019
@offtherailz offtherailz merged commit 5c8f7e9 into geosolutions-it:master May 9, 2019
@tdipisa
Copy link
Member

tdipisa commented May 10, 2019

@kappu72 please backport this to the 2019.01.xx branch.

kappu72 added a commit to kappu72/MapStore2 that referenced this pull request May 10, 2019
@kappu72
Closes geosolutions-it#3534 switch content tab when 0 results (maps/d…
fc4a2b9 
…ashboards) (geosolutions-it#3733)

(cherry picked from commit 5c8f7e9)
offtherailz pushed a commit that referenced this pull request May 13, 2019
@kappu72 @offtherailz
Closes #3534 switch content tab when 0 results (maps/dashboards) (#3733…
e050580 
…) (#3746)

(cherry picked from commit 5c8f7e9)
@offtherailz offtherailz mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@offtherailz offtherailz

@kappu72 kappu72

Labels
Priority: High
Projects
None yet
Milestone
2019.01.01
Development

Successfully merging this pull request may close these issues.

Home page search of Map and Dashboard
4 participants
@kappu72 @coveralls @tdipisa @offtherailz