Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9216: handle fixing not visibility of spatial filter for widgets created by attribute table #9674

Merged
merged 3 commits into from
Nov 10, 2023
Merged

#9216: handle fixing not visibility of spatial filter for widgets created by attribute table #9674

merged 3 commits into from
Nov 10, 2023

Conversation

mahmoudadel54
Copy link
Contributor

Description

Handle fixing not visibility of spatial filter for widgets that created by the attribute table

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#9216

What is the current behavior?
#9216

What is the new behavior?
If user makes a spatial filter via attribute table then wants to create a widget from attribute table - like a chart widget for example - and wants to apply the same spatial filter on the widget.
By clicking on spatial filter button on the chart widget, user can see the applied spatial filter on map.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@mahmoudadel54 mahmoudadel54 added this to the 2023.02.01 milestone Oct 30, 2023
@mahmoudadel54 mahmoudadel54 requested a review from MV88 October 30, 2023 03:02
@mahmoudadel54 mahmoudadel54 self-assigned this Oct 30, 2023
@mahmoudadel54 mahmoudadel54 linked an issue Oct 30, 2023 that may be closed by this pull request
Spatial filter is not visible for widgets created by the attribute table #9216
Closed
1 task
MV88
MV88 requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide more info

web/client/epics/widgetsbuilder.js Outdated Show resolved Hide resolved
web/client/epics/widgetsbuilder.js Outdated Show resolved Hide resolved
web/client/epics/widgetsbuilder.js Outdated Show resolved Hide resolved
@mahmoudadel54 mahmoudadel54 requested a review from MV88 November 6, 2023 21:19
MV88
MV88 requested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are not adding "widgets" when calling featureTypeSelected in the e widgetsBuilder epic

missing tests for actions

web/client/actions/wfsquery.js Show resolved Hide resolved
web/client/actions/wfsquery.js Show resolved Hide resolved
web/client/actions/wfsquery.js Show resolved Hide resolved
@mahmoudadel54 mahmoudadel54 requested a review from MV88 November 10, 2023 15:54
@MV88 MV88 merged commit 8321e75 into geosolutions-it:master Nov 10, 2023
4 checks passed
@MV88
Copy link
Contributor

MV88 commented Nov 10, 2023

@ElenaGallo please test it in DEV

@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 10, 2023
@ElenaGallo
Copy link
Contributor

Test passed, @mahmoudadel54 please backport this to 2023.02.xx branch. Thanks

@tdipisa
Copy link
Member

tdipisa commented Nov 13, 2023 •
edited
Loading

@mahmoudadel54 @MV88 before backporting this PR I would like to clarify if this new issue created by @ElenaGallo is connected to the development made within this PR.
If yes, the milestone of the new issue should change accordingly @ElenaGallo

@mahmoudadel54
Copy link
Contributor Author

@mahmoudadel54 @MV88 before backporting this PR I would like to clarify if this new issue created by @ElenaGallo is connected to the development made within this PR. If yes, the milestone of the new issue should change accordingly @ElenaGallo

I have checked this issue #9697 , it has been existing before this PR.
@tdipisa @MV88

@tdipisa
Copy link
Member

tdipisa commented Nov 14, 2023 •
edited
Loading

Got it and I've better checked the issue description. It is not connected with this PR. Thank you @mahmoudadel54, please proceed with the backport.

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this pull request Nov 15, 2023
@mahmoudadel54
geosolutions-it#9216: handle fixing not visibility of spatial filter …
62c043a 
…for widgets created by attribute table (geosolutions-it#9674)

* geosolutions-it#9216: handle fixing not visibility of spatial filter for widgets that created by the attr table
@mahmoudadel54 mahmoudadel54 mentioned this pull request Nov 15, 2023
Merged
@mahmoudadel54
Copy link
Contributor Author

Test passed, @mahmoudadel54 please backport this to 2023.02.xx branch. Thanks

Backport is done ---> #9704

MV88 pushed a commit that referenced this pull request Nov 15, 2023
@mahmoudadel54
#9216: handle fixing not visibility of spatial filter for widgets cre…
cdcb22e 
…ated by attribute table (#9674) (#9704)

* #9216: handle fixing not visibility of spatial filter for widgets that created by the attr table
@ElenaGallo ElenaGallo removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@mahmoudadel54 mahmoudadel54

Labels
bug Internal
Projects
None yet
Milestone
2023.02.01
Development

Successfully merging this pull request may close these issues.

Spatial filter is not visible for widgets created by the attribute table
4 participants
@mahmoudadel54 @MV88 @ElenaGallo @tdipisa