multi-stage gif integration #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gertrude-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gertrude-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gertrude-parents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kiahjh
approved these changes
Jan 16, 2024
| import assets from '../cdn-assets'; | ||
|
|
||
| const HowToUseGifs: React.FC = () => ( | ||
| <Onboarding.Centered className="space-x-12" direction="row"> |
There was a problem hiding this comment.
I really like how easy it is to make consistent, nice-looking screens going forward with our little ui library 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the most substantial part of these changes has to do with the timing of the multi-gifs. took me a while to realize it, but as originally implemented, all of the multi-gifs started playing and looping right when the onboarding flow rendered, and continued looping throughout. this was good for preloading the images, but meant that when a user got to a step that had a multi-gif, they might find that the were looking at the 3rd stage, which is kind of disorienting. so i made a special context that allowed the
ExpandableContentto basically ask "am i the step being seen by the user right now", and delay kicking off the timing/looping until then, while still preloading.i also added two new steps, one for showing how to use the multi-stage gifs, and another to warn people about not clicking the wrong button in the system extension install flow (which is easy to do, and hard to recover from)