New marketing site #315
New marketing site #315
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for gertrude-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Waiting for the first build to start… |
|
PR for changed screenshots: #317 |
✅ Deploy Preview for gertrude-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kiahjh
force-pushed
the
new-marketing-site
branch
from
6938a71 to
ce8f9be
Compare
✅ Deploy Preview for gertrude-parents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gertrude-parents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kiahjh
force-pushed
the
new-marketing-site
branch
from
ce8f9be to
741545c
Compare
kiahjh
force-pushed
the
new-marketing-site
branch
from
49fb666 to
79ef1fd
Compare
kiahjh
force-pushed
the
new-marketing-site
branch
from
79ef1fd to
de9541a
Compare
There was a problem hiding this comment.
This is a huge amount of work, thanks so much. All of it looks so amazing. The scrolly stuff is pure wizardry.
I have another chunk of review work to do, I want to crawl around the site in a browser and check a bunch of things, so I'll probably leave some comments from that as well, so my review isn't fully done, but I think i'll submit these comments in case you want to address some of them.
couple non-code things i also wanted to mention:
- 404 pages seem to be white-screening with a console error, instead of showing some kind of 404
- we have some broken links in the docs/blog area, like for instance the iphone lockdown article, where i link to "5 things you forgot", that link is now broken. we should probably carefully check all of the markdown links
- seems a little sub-optimal that the documentation pages don't link to the blog anywhere, not even in a footer... is there a place that would make sense? come to think of it, it might be worth having a couple other links too, like at least to the "contact" page.
- the 3 iphone-lockdown articles i feel a little torn about. while they're not documentation for gertrude, i feel a little sad that they're only findable through the blog link. i wonder if we could find a spot for just those 3 in the docs page sidebar or something? they're pretty valuable articles. i think most of our traffic for those comes from google (which should be unnaffected if we do redirects correct, i think linking more prominently to them would be nice, if we could do it in a way that felt non-cluttery.
| Contact us | ||
| </h1> | ||
| <p className="text-xl mt-3 text-slate-500 max-w-2xl self-center lg:self-start text-center lg:text-left relative"> | ||
| Lorem ipsum dolor sit amet, qui minim labore adipisicing minim sint cillum sint |
There was a problem hiding this comment.
did you have a thought for some text here? or should i write something?
There was a problem hiding this comment.
Not really... ¯\_(ツ)_/¯
| className, | ||
| )} | ||
| > | ||
| {/* dock */} |
site/public/feature-cards/family.gif
Outdated
There was a problem hiding this comment.
can you check if we could somehow optimize the animated gifs keeping most of the quality but getting the filesize down? or have you already looked into that?
|
viewing a docs page on my phone gives me huge horizontal scrolling (at least on |
|
the buttons at the bottom of the sidebar aren't quite visible on my phone, see:
|
|
i'm wondering a little bit about the lack of a persistent nav in the docs on mobile. if you scroll down to the bottom of an article, you're sort of stuck, the only way to keep reading is to scroll all the way back to the top to click the hamburger. you have any thoughts on that? |
|
hmm... the hero block renders off-center on my phone:
|
|
i might need to show you this on my phone, but the "peace of mind for parents" block is super easy to scroll past. like if you give one solid scroll from the top, it comes into view and goes blurry before you have a chance to read it. i wonder if we could make it "pause" a little bit and require a second thumb to move on? |
|
in the block shown below, the content goes right to the very edge on small screens. i would think a little breathing room would be nice, unless you did that on purpose and thought it was better this way.
|
|
this padding or spacing below the content and above the footer seems a little strange to me on mobile at least... feels like it might be nice to just transition straight from the black block to the footer.
|
|
wow, the super scroller block looks incredible on my phone. 💯 |
|
i don't think the "watch demo video" works anymore. |
|
the "step by step guide" link at the bottom of the home page seems to link to the wrong thing. |
kiahjh
force-pushed
the
new-marketing-site
branch
from
1229ba8 to
a87f4a1
Compare
kiahjh
force-pushed
the
new-marketing-site
branch
from
a87f4a1 to
b91e27c
Compare
kiahjh
force-pushed
the
new-marketing-site
branch
from
b91e27c to
d7821de
Compare
closes https://github.com/gertrude-app/project/issues/207