appviews: compat fixes for catalina 2.5.0 ui changes #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying gertrude-parents with
|
| Latest commit: |
ffe5f78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://38889ed5.parents.pages.dev |
| Branch Preview URL: | https://catalina-appview-fixes.parents.pages.dev |
jaredh159
commented
Nov 14, 2024
| @@ -33,6 +33,6 @@ | |||
| "x-exec": "^1.2.0" | |||
| }, | |||
| "browserslist": [ | |||
| "Safari > 14" | |||
| "Safari > 13" | |||
There was a problem hiding this comment.
this fixed the background-clip: text issue by producing -webkit-background-clip css
Deploying gertrude-storybook with
|
| Latest commit: |
ffe5f78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ead544d9.gertrude-storybook.pages.dev |
| Branch Preview URL: | https://catalina-appview-fixes.gertrude-storybook.pages.dev |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
jaredh159
commented
Nov 14, 2024
| @@ -13,7 +13,7 @@ const PauseDowntimeModal: React.FC<Props> = ({ open, emit, dispatch }) => ( | |||
| <> | |||
| <div | |||
| className={cx( | |||
| `bg-white/50 dark:bg-white/10 backdrop-blur shadow-lg absolute z-20 px-3 py-2 rounded-xl w-80 transition-[opacity,transform] duration-300`, | |||
| `bg-white/50 dark:bg-white/10 shadow-lg absolute z-20 px-3 py-2 rounded-xl w-80 transition-[opacity,transform] duration-300`, | |||
There was a problem hiding this comment.
this class was causing the bug shown here in catalina. i couldn't see any visible effect from removing it either, so hopefully it's ok.
jaredh159
commented
Nov 14, 2024
| @@ -26,18 +26,21 @@ const PauseDowntimeModal: React.FC<Props> = ({ open, emit, dispatch }) => ( | |||
| <i className="fa fa-times text-black/40 dark:text-white/70 text-sm bg-black/10 dark:bg-white/10 w-5 h-5 rounded-full flex justify-center items-center hover:bg-black/20 dark:hover:bg-white/20 hover:scale-110 active:bg-black/30 dark:active:bg-white/30 active:scale-95 transition-[background-color,transform] duration-200" /> | |||
| </button> | |||
| </header> | |||
| <div className="flex flex-wrap justify-center gap-2 py-4"> | |||
There was a problem hiding this comment.
here's the gap i had to replace
Deploying gertrude-site with
|
| Latest commit: |
ffe5f78
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://abb804b2.gertrude-site.pages.dev |
| Branch Preview URL: | https://catalina-appview-fixes.gertrude-site.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.